Revert changes from #58314 breaking build on FreeBSD. #59004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsPR #58314 replaced some build-configuration files tweaked by the FreeBSD community in order to make .NET build on FreeBSD. PR dotnet/arcade#7885 fixes these changes upstream in
|
jkotas
approved these changes
Sep 12, 2021
|
Thanks again for getting this fixed! |
Thefrank
approved these changes
Sep 12, 2021
|
I'm pretty sure most of the CI-failures here are temporal and due to errors on the agent. Can anyone re-queue the build? 😄 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #58314 replaced some build-configuration files tweaked by the FreeBSD community in order to make .NET build on FreeBSD.
PR dotnet/arcade#7885 fixes these changes upstream in
dotnet/arcadeto prevent future regressions, but we still need to revert the changes in runtime too, to make the build run.CC: @jkotas @Thefrank